Re: [PATCH v2 06/11] media: qcom: iris: don't use function indirection in gen2-specific code

[Dikshita Agarwal]

On 2/28/2026 8:56 PM, Dmitry Baryshkov wrote:
> To note that iris_set_num_comv() is gen2-internal, rename it to
> iris_hfi_gen2_set_num_comv() and then stop using hfi_ops indirection to
> set session property (like other functions in this file do).
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>
> ---
>  drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c b/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c
> index fd8a055c4acc..93ce7ac3a19c 100644
> --- a/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c
> +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c
> @@ -1295,7 +1295,7 @@ static u32 iris_hfi_gen2_buf_type_from_driver(u32 domain, enum iris_buffer_type
>  	}
>  }
>  
> -static int iris_set_num_comv(struct iris_inst *inst)
> +static int iris_hfi_gen2_set_num_comv(struct iris_inst *inst)
>  {
>  	struct platform_inst_caps *caps;
>  	struct iris_core *core = inst->core;
> @@ -1310,12 +1310,12 @@ static int iris_set_num_comv(struct iris_inst *inst)
>  	num_comv = (inst->codec == V4L2_PIX_FMT_AV1) ?
>  				NUM_COMV_AV1 : caps->num_comv;
>  
> -	return core->hfi_ops->session_set_property(inst,
> -						   HFI_PROP_COMV_BUFFER_COUNT,
> -						   HFI_HOST_FLAGS_NONE,
> -						   HFI_PORT_BITSTREAM,
> -						   HFI_PAYLOAD_U32,
> -						   &num_comv, sizeof(u32));
> +	return iris_hfi_gen2_session_set_property(inst,
> +						  HFI_PROP_COMV_BUFFER_COUNT,
> +						  HFI_HOST_FLAGS_NONE,
> +						  HFI_PORT_BITSTREAM,
> +						  HFI_PAYLOAD_U32,
> +						  &num_comv, sizeof(u32));
>  }
>  
>  static void iris_hfi_gen2_get_buffer(u32 domain, struct iris_buffer *buffer,
> @@ -1347,7 +1347,7 @@ static int iris_hfi_gen2_session_queue_buffer(struct iris_inst *inst, struct iri
>  
>  	iris_hfi_gen2_get_buffer(inst->domain, buffer, &hfi_buffer);
>  	if (buffer->type == BUF_COMV) {
> -		ret = iris_set_num_comv(inst);
> +		ret = iris_hfi_gen2_set_num_comv(inst);
>  		if (ret)
>  			return ret;
>  	}
> 

Reviewed-by: Dikshita Agarwal <dikshita.agarwal@xxxxxxxxxxxxxxxx>

Thanks,
Dikshita