Re: [PATCH v2 1/2] dt-bindings: display: panel: Add Himax HX83121A

[Krzysztof Kozlowski]

On Thu, Mar 05, 2026 at 04:48:09PM +0800, Pengyu Luo wrote:
> HX83121A is a driver IC used to drive MIPI-DSI panels. It is found
> in HUAWEI Matebook E Go series (Gaokun2/3) with BOE or CSOT panels.
> 
> Signed-off-by: Pengyu Luo <mitltlatltl@xxxxxxxxx>
> ---
>  .../display/panel/himax,hx83121a.yaml         | 92 +++++++++++++++++++
>  1 file changed, 92 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/panel/himax,hx83121a.yaml
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/himax,hx83121a.yaml b/Documentation/devicetree/bindings/display/panel/himax,hx83121a.yaml
> new file mode 100644
> index 000000000..b6bcace29
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/himax,hx83121a.yaml
> @@ -0,0 +1,92 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/himax,hx83121a.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Himax HX83121A based DSI display Panels
> +
> +maintainers:
> +  - Pengyu Luo <mitltlatltl@xxxxxxxxx>
> +
> +description: |

Do not need '|' unless you need to preserve formatting.

> +  The Himax HX83121A is a generic DSI Panel IC used to drive dsi
> +  panels. Support video mode panels from China Star Optoelectronics
> +  Technology (CSOT) and BOE Technology.
> +
> +allOf:
> +  - $ref: panel-common-dual.yaml#
> +
> +properties:
> +  compatible:
> +    items:
> +      - enum:
> +          - boe,ppc357db1-4
> +          - csot,ppc357db1-4
> +      - const: himax,hx83121a
> +
> +  reg:
> +    maxItems: 1
> +
> +  reset-gpios:
> +    maxItems: 1
> +    description: phandle of gpio for reset line

Drop description


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>

Best regards,
Krzysztof