Re: [PATCH net-next v2 2/3] bnxt_en: Resize RSS contexts on channel count change

[Björn Töpel]

Jakub!

On Fri, 6 Mar 2026 at 04:05, Jakub Kicinski <kuba@xxxxxxxxxx> wrote:
>
> On Wed,  4 Mar 2026 14:18:52 +0100 Björn Töpel wrote:
> > +             if (netif_is_rxfh_configured(dev) &&
> > +                 ethtool_rxfh_can_resize(bp->rss_indir_tbl,
> > +                                         old_tbl_size, new_tbl_size)) {
>
> Doesn't this read a little odd? Shouldn't ethtool_rxfh_can_resize()
> return true when ... we can resize? You end up ignoring the real rc
> here, and it can only ever be -EINVAL.

Yeah, it does. I'll change to return a bool, and inverse the check!

Thanks,
Björn