Re: [PATCH 0/4] iio: adc: ad4691: add driver for AD4691 multichannel SAR ADC family
From: Andy Shevchenko
Date: Fri Mar 06 2026 - 09:36:13 EST
On Fri, Mar 06, 2026 at 12:39:30PM +0000, Sabau, Radu bogdan wrote:
> > -----Original Message-----
> > From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>
> > Sent: Friday, March 6, 2026 2:06 PM
> > On Thu, Mar 05, 2026 at 02:23:26PM +0200, Radu Sabau via B4 Relay wrote:
...
> > This cover letter doesn't answer to the first important question: Why a brand
> > new driver? Do your homework and check what is already in the kernel and
> > explain in the next version why no other existing driver can be reused (refactored).
>
> Indeed at first glance I thought about adding support for these parts in the existing
> AD4965 driver. The registers indeed are a bit similar between them, but the
> channel specific registers are completely different, and more than this the
> conversion modes are different.
> With this being said, I will try and make things more clear by answering this
> question in the cover letter of the next patch. Thank you for pointing this out.
Good, the summary of the above will fulfil the request, thanks.
--
With Best Regards,
Andy Shevchenko