Re: [PATCH] iio: adc: ti-ads1119: Drop redundant error message
From: Jonathan Cameron
Date: Sat Mar 07 2026 - 08:25:58 EST
On Tue, 03 Mar 2026 01:07:29 +0800
Felix Gu <ustc.gu@xxxxxxxxx> wrote:
> devm_request_threaded_irq already prints an error message when failure,
> so the error message is redundant, drop it.
>
> Suggested-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>
> Signed-off-by: Felix Gu <ustc.gu@xxxxxxxxx>
Hmm. I applied this already and for some reason didn't reply to say so.
So applied.
J
> ---
> drivers/iio/adc/ti-ads1119.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/iio/adc/ti-ads1119.c b/drivers/iio/adc/ti-ads1119.c
> index c9cedc59cdcd..1157e606bc64 100644
> --- a/drivers/iio/adc/ti-ads1119.c
> +++ b/drivers/iio/adc/ti-ads1119.c
> @@ -740,8 +740,7 @@ static int ads1119_probe(struct i2c_client *client)
> NULL, IRQF_ONESHOT,
> "ads1119", indio_dev);
> if (ret)
> - return dev_err_probe(dev, ret,
> - "Failed to allocate irq\n");
> + return ret;
>
> st->trig = devm_iio_trigger_alloc(dev, "%s-dev%d",
> indio_dev->name,
>
> ---
> base-commit: 3fa5e5702a82d259897bd7e209469bc06368bf31
> change-id: 20260303-ti-ads1119-2-73294fc211a7
>
> Best regards,