[PATCH] iio: adc: ti-ads7950: remove chip_info[]
From: David Lechner
Date: Sat Mar 07 2026 - 16:55:00 EST
Remove the chip_info[] array and related enum used for looking up chip-
specific information. Instead, use individual structs directly in the
module device tables.
Also update to use spi_get_device_match_data() in case the devicetree
table is ever used instead of the SPI device ID table.
Signed-off-by: David Lechner <dlechner@xxxxxxxxxxxx>
---
Tested on LEGO MINDSTORMS EV3.
This will probably have some fuzz when applying on top of some of the
other patches for this driver currently in flight, but I don't think
anything that will require a manual intervention.
To be safe though, we can hold off on applying this until the other
patches have landed.
---
drivers/iio/adc/ti-ads7950.c | 172 +++++++++++++++++++++----------------------
1 file changed, 83 insertions(+), 89 deletions(-)
diff --git a/drivers/iio/adc/ti-ads7950.c b/drivers/iio/adc/ti-ads7950.c
index bbe1ce577789..fa3b446495ec 100644
--- a/drivers/iio/adc/ti-ads7950.c
+++ b/drivers/iio/adc/ti-ads7950.c
@@ -118,21 +118,6 @@ struct ti_ads7950_chip_info {
unsigned int num_channels;
};
-enum ti_ads7950_id {
- TI_ADS7950,
- TI_ADS7951,
- TI_ADS7952,
- TI_ADS7953,
- TI_ADS7954,
- TI_ADS7955,
- TI_ADS7956,
- TI_ADS7957,
- TI_ADS7958,
- TI_ADS7959,
- TI_ADS7960,
- TI_ADS7961,
-};
-
#define TI_ADS7950_V_CHAN(index, bits) \
{ \
.type = IIO_VOLTAGE, \
@@ -225,55 +210,64 @@ static DECLARE_TI_ADS7950_8_CHANNELS(ti_ads7959, 8);
static DECLARE_TI_ADS7950_12_CHANNELS(ti_ads7960, 8);
static DECLARE_TI_ADS7950_16_CHANNELS(ti_ads7961, 8);
-static const struct ti_ads7950_chip_info ti_ads7950_chip_info[] = {
- [TI_ADS7950] = {
- .channels = ti_ads7950_channels,
- .num_channels = ARRAY_SIZE(ti_ads7950_channels),
- },
- [TI_ADS7951] = {
- .channels = ti_ads7951_channels,
- .num_channels = ARRAY_SIZE(ti_ads7951_channels),
- },
- [TI_ADS7952] = {
- .channels = ti_ads7952_channels,
- .num_channels = ARRAY_SIZE(ti_ads7952_channels),
- },
- [TI_ADS7953] = {
- .channels = ti_ads7953_channels,
- .num_channels = ARRAY_SIZE(ti_ads7953_channels),
- },
- [TI_ADS7954] = {
- .channels = ti_ads7954_channels,
- .num_channels = ARRAY_SIZE(ti_ads7954_channels),
- },
- [TI_ADS7955] = {
- .channels = ti_ads7955_channels,
- .num_channels = ARRAY_SIZE(ti_ads7955_channels),
- },
- [TI_ADS7956] = {
- .channels = ti_ads7956_channels,
- .num_channels = ARRAY_SIZE(ti_ads7956_channels),
- },
- [TI_ADS7957] = {
- .channels = ti_ads7957_channels,
- .num_channels = ARRAY_SIZE(ti_ads7957_channels),
- },
- [TI_ADS7958] = {
- .channels = ti_ads7958_channels,
- .num_channels = ARRAY_SIZE(ti_ads7958_channels),
- },
- [TI_ADS7959] = {
- .channels = ti_ads7959_channels,
- .num_channels = ARRAY_SIZE(ti_ads7959_channels),
- },
- [TI_ADS7960] = {
- .channels = ti_ads7960_channels,
- .num_channels = ARRAY_SIZE(ti_ads7960_channels),
- },
- [TI_ADS7961] = {
- .channels = ti_ads7961_channels,
- .num_channels = ARRAY_SIZE(ti_ads7961_channels),
- },
+static const struct ti_ads7950_chip_info ti_ads7950_chip_info = {
+ .channels = ti_ads7950_channels,
+ .num_channels = ARRAY_SIZE(ti_ads7950_channels),
+};
+
+static const struct ti_ads7950_chip_info ti_ads7951_chip_info = {
+ .channels = ti_ads7951_channels,
+ .num_channels = ARRAY_SIZE(ti_ads7951_channels),
+};
+
+static const struct ti_ads7950_chip_info ti_ads7952_chip_info = {
+ .channels = ti_ads7952_channels,
+ .num_channels = ARRAY_SIZE(ti_ads7952_channels),
+};
+
+static const struct ti_ads7950_chip_info ti_ads7953_chip_info = {
+ .channels = ti_ads7953_channels,
+ .num_channels = ARRAY_SIZE(ti_ads7953_channels),
+};
+
+static const struct ti_ads7950_chip_info ti_ads7954_chip_info = {
+ .channels = ti_ads7954_channels,
+ .num_channels = ARRAY_SIZE(ti_ads7954_channels),
+};
+
+static const struct ti_ads7950_chip_info ti_ads7955_chip_info = {
+ .channels = ti_ads7955_channels,
+ .num_channels = ARRAY_SIZE(ti_ads7955_channels),
+};
+
+static const struct ti_ads7950_chip_info ti_ads7956_chip_info = {
+ .channels = ti_ads7956_channels,
+ .num_channels = ARRAY_SIZE(ti_ads7956_channels),
+};
+
+static const struct ti_ads7950_chip_info ti_ads7957_chip_info = {
+ .channels = ti_ads7957_channels,
+ .num_channels = ARRAY_SIZE(ti_ads7957_channels),
+};
+
+static const struct ti_ads7950_chip_info ti_ads7958_chip_info = {
+ .channels = ti_ads7958_channels,
+ .num_channels = ARRAY_SIZE(ti_ads7958_channels),
+};
+
+static const struct ti_ads7950_chip_info ti_ads7959_chip_info = {
+ .channels = ti_ads7959_channels,
+ .num_channels = ARRAY_SIZE(ti_ads7959_channels),
+};
+
+static const struct ti_ads7950_chip_info ti_ads7960_chip_info = {
+ .channels = ti_ads7960_channels,
+ .num_channels = ARRAY_SIZE(ti_ads7960_channels),
+};
+
+static const struct ti_ads7950_chip_info ti_ads7961_chip_info = {
+ .channels = ti_ads7961_channels,
+ .num_channels = ARRAY_SIZE(ti_ads7961_channels),
};
/*
@@ -561,7 +555,7 @@ static int ti_ads7950_probe(struct spi_device *spi)
st->spi = spi;
- info = &ti_ads7950_chip_info[spi_get_device_id(spi)->driver_data];
+ info = spi_get_device_match_data(spi);
indio_dev->name = spi_get_device_id(spi)->name;
indio_dev->modes = INDIO_DIRECT_MODE;
@@ -683,35 +677,35 @@ static void ti_ads7950_remove(struct spi_device *spi)
}
static const struct spi_device_id ti_ads7950_id[] = {
- { "ads7950", TI_ADS7950 },
- { "ads7951", TI_ADS7951 },
- { "ads7952", TI_ADS7952 },
- { "ads7953", TI_ADS7953 },
- { "ads7954", TI_ADS7954 },
- { "ads7955", TI_ADS7955 },
- { "ads7956", TI_ADS7956 },
- { "ads7957", TI_ADS7957 },
- { "ads7958", TI_ADS7958 },
- { "ads7959", TI_ADS7959 },
- { "ads7960", TI_ADS7960 },
- { "ads7961", TI_ADS7961 },
+ { "ads7950", (kernel_ulong_t)&ti_ads7950_chip_info },
+ { "ads7951", (kernel_ulong_t)&ti_ads7951_chip_info },
+ { "ads7952", (kernel_ulong_t)&ti_ads7952_chip_info },
+ { "ads7953", (kernel_ulong_t)&ti_ads7953_chip_info },
+ { "ads7954", (kernel_ulong_t)&ti_ads7954_chip_info },
+ { "ads7955", (kernel_ulong_t)&ti_ads7955_chip_info },
+ { "ads7956", (kernel_ulong_t)&ti_ads7956_chip_info },
+ { "ads7957", (kernel_ulong_t)&ti_ads7957_chip_info },
+ { "ads7958", (kernel_ulong_t)&ti_ads7958_chip_info },
+ { "ads7959", (kernel_ulong_t)&ti_ads7959_chip_info },
+ { "ads7960", (kernel_ulong_t)&ti_ads7960_chip_info },
+ { "ads7961", (kernel_ulong_t)&ti_ads7961_chip_info },
{ }
};
MODULE_DEVICE_TABLE(spi, ti_ads7950_id);
static const struct of_device_id ads7950_of_table[] = {
- { .compatible = "ti,ads7950", .data = &ti_ads7950_chip_info[TI_ADS7950] },
- { .compatible = "ti,ads7951", .data = &ti_ads7950_chip_info[TI_ADS7951] },
- { .compatible = "ti,ads7952", .data = &ti_ads7950_chip_info[TI_ADS7952] },
- { .compatible = "ti,ads7953", .data = &ti_ads7950_chip_info[TI_ADS7953] },
- { .compatible = "ti,ads7954", .data = &ti_ads7950_chip_info[TI_ADS7954] },
- { .compatible = "ti,ads7955", .data = &ti_ads7950_chip_info[TI_ADS7955] },
- { .compatible = "ti,ads7956", .data = &ti_ads7950_chip_info[TI_ADS7956] },
- { .compatible = "ti,ads7957", .data = &ti_ads7950_chip_info[TI_ADS7957] },
- { .compatible = "ti,ads7958", .data = &ti_ads7950_chip_info[TI_ADS7958] },
- { .compatible = "ti,ads7959", .data = &ti_ads7950_chip_info[TI_ADS7959] },
- { .compatible = "ti,ads7960", .data = &ti_ads7950_chip_info[TI_ADS7960] },
- { .compatible = "ti,ads7961", .data = &ti_ads7950_chip_info[TI_ADS7961] },
+ { .compatible = "ti,ads7950", .data = &ti_ads7950_chip_info },
+ { .compatible = "ti,ads7951", .data = &ti_ads7951_chip_info },
+ { .compatible = "ti,ads7952", .data = &ti_ads7952_chip_info },
+ { .compatible = "ti,ads7953", .data = &ti_ads7953_chip_info },
+ { .compatible = "ti,ads7954", .data = &ti_ads7954_chip_info },
+ { .compatible = "ti,ads7955", .data = &ti_ads7955_chip_info },
+ { .compatible = "ti,ads7956", .data = &ti_ads7956_chip_info },
+ { .compatible = "ti,ads7957", .data = &ti_ads7957_chip_info },
+ { .compatible = "ti,ads7958", .data = &ti_ads7958_chip_info },
+ { .compatible = "ti,ads7959", .data = &ti_ads7959_chip_info },
+ { .compatible = "ti,ads7960", .data = &ti_ads7960_chip_info },
+ { .compatible = "ti,ads7961", .data = &ti_ads7961_chip_info },
{ }
};
MODULE_DEVICE_TABLE(of, ads7950_of_table);
---
base-commit: 6f25a6105c41a7d6b12986dbe80ded396a5667f8
change-id: 20260307-iio-adc-ti-ads7950-no-info-array-95f3b97a542c
Best regards,
--
David Lechner <dlechner@xxxxxxxxxxxx>