[PATCH] IB/hfi1: kzalloc to kzalloc_flex
From: Rosen Penev
Date: Sat Mar 07 2026 - 22:20:28 EST
Combine kzalloc and kcalloc with a flexible array member. Avoids having
to free separately.
Signed-off-by: Rosen Penev <rosenp@xxxxxxxxx>
---
drivers/infiniband/hw/hfi1/user_exp_rcv.c | 10 +---------
drivers/infiniband/hw/hfi1/user_exp_rcv.h | 2 +-
2 files changed, 2 insertions(+), 10 deletions(-)
diff --git a/drivers/infiniband/hw/hfi1/user_exp_rcv.c b/drivers/infiniband/hw/hfi1/user_exp_rcv.c
index 5b01070ed66f..2597d311fb1f 100644
--- a/drivers/infiniband/hw/hfi1/user_exp_rcv.c
+++ b/drivers/infiniband/hw/hfi1/user_exp_rcv.c
@@ -257,7 +257,7 @@ int hfi1_user_exp_rcv_setup(struct hfi1_filedata *fd,
if (tinfo->length == 0)
return -EINVAL;
- tidbuf = kzalloc(sizeof(*tidbuf), GFP_KERNEL);
+ tidbuf = kzalloc_flex(*tidbuf, psets, uctxt->expected_count);
if (!tidbuf)
return -ENOMEM;
@@ -265,12 +265,6 @@ int hfi1_user_exp_rcv_setup(struct hfi1_filedata *fd,
tidbuf->vaddr = tinfo->vaddr;
tidbuf->length = tinfo->length;
tidbuf->npages = num_user_pages(tidbuf->vaddr, tidbuf->length);
- tidbuf->psets = kcalloc(uctxt->expected_count, sizeof(*tidbuf->psets),
- GFP_KERNEL);
- if (!tidbuf->psets) {
- ret = -ENOMEM;
- goto fail_release_mem;
- }
if (fd->use_mn) {
ret = mmu_interval_notifier_insert(
@@ -448,7 +442,6 @@ int hfi1_user_exp_rcv_setup(struct hfi1_filedata *fd,
if (fd->use_mn)
mmu_interval_notifier_remove(&tidbuf->notifier);
kfree(tidbuf->pages);
- kfree(tidbuf->psets);
kfree(tidbuf);
kfree(tidlist);
return 0;
@@ -471,7 +464,6 @@ int hfi1_user_exp_rcv_setup(struct hfi1_filedata *fd,
unpin_rcv_pages(fd, tidbuf, NULL, 0, pinned, false);
fail_release_mem:
kfree(tidbuf->pages);
- kfree(tidbuf->psets);
kfree(tidbuf);
kfree(tidlist);
return ret;
diff --git a/drivers/infiniband/hw/hfi1/user_exp_rcv.h b/drivers/infiniband/hw/hfi1/user_exp_rcv.h
index 055726f7c139..b4a309a051f9 100644
--- a/drivers/infiniband/hw/hfi1/user_exp_rcv.h
+++ b/drivers/infiniband/hw/hfi1/user_exp_rcv.h
@@ -22,8 +22,8 @@ struct tid_user_buf {
unsigned long length;
unsigned int npages;
struct page **pages;
- struct tid_pageset *psets;
unsigned int n_psets;
+ struct tid_pageset psets[];
};
struct tid_rb_node {
--
2.53.0