Re: [PATCH v2 1/2] dt-bindings: hwmon: Add TI INA4230 4-channel I2C power monitor

[Alexey Charkov]

On Sun, Mar 8, 2026 at 9:46 PM Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
>
> On 3/2/26 02:55, Alexey Charkov wrote:
> > Add TI INA4230, which is a 48V 4-channel 16-bit I2C-based
> > current/voltage/power/energy monitor with alert function.
> >
> > Link: https://www.ti.com/product/INA4230
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Alexey Charkov <alchark@xxxxxxxxxxx>
> > ---
> >   .../devicetree/bindings/hwmon/ti,ina4230.yaml      | 130 +++++++++++++++++++++
> >   MAINTAINERS                                        |   6 +
> >   2 files changed, 136 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/hwmon/ti,ina4230.yaml b/Documentation/devicetree/bindings/hwmon/ti,ina4230.yaml
> > new file mode 100644
> > index 000000000000..69839e7a3197
> ...
> > +      ti,maximum-expected-current-microamp:
> > +        description: |
> > +          This value indicates the maximum current in microamps that you can
> > +          expect to measure with ina4230 in your circuit.
> > +
> > +          This value will be used to calculate the Current_LSB and current/power
> > +          coefficient for the pmbus and to calibrate the IC.
>
> pmbus ? Is this a typo or cut-and-paste error ? This is not a PMBus chip.

Indeed, cut-and-paste from ina3221 which I used as the basis for
making this one. Thanks for spotting, will fix in the next version.

Perhaps it should say this instead:

This value will be used to calculate the Current_LSB to maximize
available precision while ensuring your expected maximum current fits
within the chip's ADC range. It will also enable built-in shunt gain
to increase ADC granularity by a factor of 4 if the provided maximum
current / shunt resistance combination does not produce more than
20.48 mV drop at the shunt.

Best regards,
Alexey