Re: [PATCH 1/4] iio: accel: bmc150: convert to guard(mutex)

[Andy Shevchenko]

On Mon, Mar 09, 2026 at 03:35:58PM +0100, Waqar Hameed wrote:
> On Mon, Mar 09, 2026 at 19:53 +0530 Rajveer Chaudhari <rajveer.chaudhari.linux@xxxxxxxxx> wrote:

[...]

> > Aligned headers in alphabatical order.
> 
> Never mix unrelated changes. This should be separate patches.

Yep, I only mentioned to place cleanup.h in the better place.

> Why? Think about traceability (bisect etc.).

It's all about maintenance and development. Easy to see where need to put
a new header if it's not present (also easier to find this at a glance).

> This comment applies to all other patches in the series as well. I'll
> just state it here and wait for V2 before taking a deeper look. 

> To be honest, I'm not even sure if sorting the headers is a "valid"
> patch. It's just cosmetics (and there seems to be no such code style
> guidelines)...

It's valid when in a series (not as just for the sake of sorting). Here
it would make sense to have it as a precursor to find the best place for
a new header inclusion to place.

Guidelines here are still missing maintainer preferences for IIO subsystem.

-- 
With Best Regards,
Andy Shevchenko