Re: [PATCH] staging: axis-fifo: remove redundant goto end
From: Josh Law
Date: Mon Mar 09 2026 - 13:22:54 EST
9 Mar 2026 17:09:53 Josh Law <hlcj1234567@xxxxxxxxx>:
> 9 Mar 2026 17:06:48 Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>:
>
>> On Mon, Mar 09, 2026 at 05:04:24PM +0000, Josh Law wrote:
>>> 9 Mar 2026 17:02:10 Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>:
>>>
>>>> On Mon, Mar 09, 2026 at 04:59:58PM +0000, Josh Law wrote:
>>>>> 9 Mar 2026 16:57:19 Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>:
>>>>>
>>>>>> …
>>>>>
>>>>> You've NAKed all 10 of my patches....?
>>>>
>>>> You have had review comments on all patches sent that I can see, did I
>>>> miss any?
>>>>
>>>> thanks,
>>>>
>>>> greg k-h
>>>
>>> You missed about 10 of my V2s
>>
>> What is the lore.kernel.org link of the patches I missed?
>>
>> I see Dan's response to your v2 series of 10 patches, which I agree
>> with, you need to address that before I can look at that again. Please
>> don't ignore his comments.
>>
>> thanks,
>>
>> greg k-h
>
> https://lore.kernel.org/all/20260301214815.2628942-1-objecting@xxxxxxxxxxxxx/
> https://lore.kernel.org/all/20260301214815.2628942-2-objecting@xxxxxxxxxxxxx/
> https://lore.kernel.org/all/20260301214815.2628942-3-objecting@xxxxxxxxxxxxx/
> https://lore.kernel.org/all/20260301214815.2628942-4-objecting@xxxxxxxxxxxxx/
> https://lore.kernel.org/all/20260301214815.2628942-5-objecting@xxxxxxxxxxxxx/
> https://lore.kernel.org/all/20260301214815.2628942-6-objecting@xxxxxxxxxxxxx/
> https://lore.kernel.org/all/20260301214815.2628942-7-objecting@xxxxxxxxxxxxx/
> https://lore.kernel.org/all/20260301214815.2628942-8-objecting@xxxxxxxxxxxxx/
> https://lore.kernel.org/all/20260301214815.2628942-9-objecting@xxxxxxxxxxxxx/
> https://lore.kernel.org/all/20260301214815.2628942-10-objecting@xxxxxxxxxxxxx/
>
>
> V/R
>
>
>
> Also, I am responding to Dan's comments, but I am focusing on lib/ at the moment, since I'm a reviewer, and I've had more time to fix lib/
>
>
> Later, the patches that Dan NAKed, I will go ahead and fix them for you
If it's convenient for you you can ignore one and two since they have no descriptions, patch 5 is worth looking at maybe.