Re: [PATCH 2/3] clk: qcom: gcc-glymur: Enable runtime PM
From: Dmitry Baryshkov
Date: Mon Mar 09 2026 - 17:33:18 EST
On Mon, Mar 09, 2026 at 12:06:18PM +0200, Abel Vesa wrote:
> It has been concluded off-list that the controller needs to scale the RPMh
> CX power domain, otherwise some of the subsystems might crash or be
Which?
> unstable. So adding the RPMh CX power domain to the controller will result
> in all GDSCs being parented by CX. This way, the vote from the consumers
> of each GDSC will trickle all the way to CX.
This seems to be irrelevant to the commit.
>
> So since there is a power domain attached to the controller, enable
> runtime PM.
And this is relevant.
>
> Fixes: efe504300a17 ("clk: qcom: gcc: Add support for Global Clock Controller")
> Signed-off-by: Abel Vesa <abel.vesa@xxxxxxxxxxxxxxxx>
> ---
> drivers/clk/qcom/gcc-glymur.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/qcom/gcc-glymur.c b/drivers/clk/qcom/gcc-glymur.c
> index 0f3981252a68..7cb5076a460f 100644
> --- a/drivers/clk/qcom/gcc-glymur.c
> +++ b/drivers/clk/qcom/gcc-glymur.c
> @@ -8578,6 +8578,7 @@ static const struct qcom_cc_desc gcc_glymur_desc = {
> .num_resets = ARRAY_SIZE(gcc_glymur_resets),
> .gdscs = gcc_glymur_gdscs,
> .num_gdscs = ARRAY_SIZE(gcc_glymur_gdscs),
> + .use_rpm = true,
> .driver_data = &gcc_glymur_driver_data,
> };
>
>
> --
> 2.48.1
>
--
With best wishes
Dmitry