Re: [PATCH V3 2/5] platform: arm64: Add driver for EC found on Qualcomm reference devices
From: kernel test robot
Date: Tue Mar 10 2026 - 02:19:41 EST
Hi Sibi,
kernel test robot noticed the following build errors:
[auto build test ERROR on a0ae2a256046c0c5d3778d1a194ff2e171f16e5f]
url: https://github.com/intel-lab-lkp/linux/commits/Sibi-Sankar/dt-bindings-embedded-controller-Add-EC-bindings-for-Qualcomm-reference-devices/20260309-074148
base: a0ae2a256046c0c5d3778d1a194ff2e171f16e5f
patch link: https://lore.kernel.org/r/20260308233646.2318676-3-sibi.sankar%40oss.qualcomm.com
patch subject: [PATCH V3 2/5] platform: arm64: Add driver for EC found on Qualcomm reference devices
config: hexagon-allmodconfig (https://download.01.org/0day-ci/archive/20260310/202603101317.ZR8NjiRC-lkp@xxxxxxxxx/config)
compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260310/202603101317.ZR8NjiRC-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202603101317.ZR8NjiRC-lkp@xxxxxxxxx/
All errors (new ones prefixed by >>):
>> drivers/platform/arm64/qcom-hamoa-ec.c:170:37: error: call to undeclared function 'FIELD_GET'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
170 | cap->fan_cnt = max(EC_MAX_FAN_CNT, EC_THERMAL_FAN_CNT(resp[1]));
| ^
drivers/platform/arm64/qcom-hamoa-ec.c:56:33: note: expanded from macro 'EC_THERMAL_FAN_CNT'
56 | #define EC_THERMAL_FAN_CNT(x) (FIELD_GET(GENMASK(1, 0), (x)))
| ^
drivers/platform/arm64/qcom-hamoa-ec.c:171:18: error: call to undeclared function 'FIELD_GET'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
171 | cap->fan_type = EC_THERMAL_FAN_TYPE(resp[1]);
| ^
drivers/platform/arm64/qcom-hamoa-ec.c:57:34: note: expanded from macro 'EC_THERMAL_FAN_TYPE'
57 | #define EC_THERMAL_FAN_TYPE(x) (FIELD_GET(GENMASK(4, 2), (x)))
| ^
2 errors generated.
vim +/FIELD_GET +170 drivers/platform/arm64/qcom-hamoa-ec.c
137
138 /*
139 * EC Device Thermal Capabilities:
140 *
141 * Read Response:
142 * ----------------------------------------------------------------------
143 * | Offset | Name | Description |
144 * ----------------------------------------------------------------------
145 * | 0x00 | Byte count | Number of bytes in response |
146 * | | | (exluding byte count) |
147 * ----------------------------------------------------------------------
148 * | 0x02 (LSB) | EC Thermal | Bit 0-1: Number of fans |
149 * | 0x3 | Capabilities | Bit 2-4: Type of fan |
150 * | | | Bit 5-6: Reserved |
151 * | | | Bit 7: Data Valid/Invalid |
152 * | | | (Valid - 1, Invalid - 0)
153 * | | | Bit 8-15: Thermistor 0 - 7 presence |
154 * | | | (0 present, 1 absent) |
155 * ----------------------------------------------------------------------
156 *
157 */
158 static int qcom_ec_thermal_capabilities(struct device *dev)
159 {
160 struct i2c_client *client = to_i2c_client(dev);
161 struct qcom_ec *ec = i2c_get_clientdata(client);
162 struct qcom_ec_thermal_cap *cap = &ec->thermal_cap;
163 u8 resp[EC_THERMAL_CAP_RESP_LEN];
164 int ret;
165
166 ret = qcom_ec_read(ec, EC_THERMAL_CAP_CMD, EC_THERMAL_CAP_RESP_LEN, resp);
167 if (ret < 0)
168 return ret;
169
> 170 cap->fan_cnt = max(EC_MAX_FAN_CNT, EC_THERMAL_FAN_CNT(resp[1]));
171 cap->fan_type = EC_THERMAL_FAN_TYPE(resp[1]);
172 cap->thermistor_mask = EC_THERMAL_THERMISTOR_MASK(resp[2]);
173
174 dev_dbg(dev, "Fan count: %d Fan Type: %d Thermistor Mask: %d\n",
175 cap->fan_cnt, cap->fan_type, cap->thermistor_mask);
176
177 return 0;
178 }
179
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki