Re: [PATCH v2 3/8] dt-bindings: phy: Document PCIe PHY in EcoNet EN751221 and EN7528

[Caleb James DeLisle]

On 10/03/2026 09:24, Krzysztof Kozlowski wrote:
> On Mon, Mar 09, 2026 at 01:18:13PM +0000, Caleb James DeLisle wrote:
> > EN751221 and EN7528 SoCs have two PCIe slots, and each one has a PHY
> > which behaves slightly differently because one slot is Gen1/Gen2 while
> > the other is Gen1 only.
> >
> > Signed-off-by: Caleb James DeLisle <cjd@xxxxxxxx>
> Still, four separate subsystems unnecessarily merged into one patchset.
> Split independent parts of your work per subsystem. See also submitting
> patches.


I asked for clarification last time and didn't get a reply. I'm not 
against changing it but need to understand exactly what's expected b/c 
the way I'm imagining it seems way worse. submitting-patches.rst only 
says of patch sets "only post say 15 or so at a time", obviously not the 
case here.

If you're asking for one patchset for phy, one for clock, one for PCI, 
and then one to introduce them to the device, I can do that. I just want 
to be sure because introducing unused code, and patch sets that depend 
on other patch sets both seem like anti-patterns to me.


Thanks,

Caleb


> > ---
> >   .../phy/econet,en751221-pcie-phy.yaml         | 50 +++++++++++++++++++
> >   MAINTAINERS                                   |  6 +++
> >   2 files changed, 56 insertions(+)
> >   create mode 100644 Documentation/devicetree/bindings/phy/econet,en751221-pcie-phy.yaml
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>
>
> Best regards,
> Krzysztof