Re: [PATCH] efi: libstub: fix type of fdt 32 and 64bit variables

From: Ard Biesheuvel

Date: Tue Mar 10 2026 - 11:14:55 EST


On Mon, 9 Mar 2026, at 18:10, Ben Dooks wrote:
> In update_fdt_memmap() an update_fdt() the fdt values should be
> of the fd32_t and fdt64_t types. Make the relevant changes to
> remove the following sparse warnings:
>
> drivers/firmware/efi/libstub/fdt.c:97:19: warning: incorrect type in
> assignment (different base types)
> drivers/firmware/efi/libstub/fdt.c:97:19: expected unsigned long
> long [usertype] fdt_val64
> drivers/firmware/efi/libstub/fdt.c:97:19: got restricted __be64
> [usertype]
> drivers/firmware/efi/libstub/fdt.c:157:19: warning: incorrect type in
> assignment (different base types)
> drivers/firmware/efi/libstub/fdt.c:157:19: expected unsigned long
> long [usertype] fdt_val64
> drivers/firmware/efi/libstub/fdt.c:157:19: got restricted __be64
> [usertype]
> drivers/firmware/efi/libstub/fdt.c:163:19: warning: incorrect type in
> assignment (different base types)
> drivers/firmware/efi/libstub/fdt.c:163:19: expected unsigned int
> [usertype] fdt_val32
> drivers/firmware/efi/libstub/fdt.c:163:19: got restricted __be32
> [usertype]
> drivers/firmware/efi/libstub/fdt.c:169:19: warning: incorrect type in
> assignment (different base types)
> drivers/firmware/efi/libstub/fdt.c:169:19: expected unsigned int
> [addressable] [usertype] fdt_val32
> drivers/firmware/efi/libstub/fdt.c:169:19: got restricted __be32
> [usertype]
> drivers/firmware/efi/libstub/fdt.c:175:19: warning: incorrect type in
> assignment (different base types)
> drivers/firmware/efi/libstub/fdt.c:175:19: expected unsigned int
> [addressable] [usertype] fdt_val32
> drivers/firmware/efi/libstub/fdt.c:175:19: got restricted __be32
> [usertype]
>
> Signed-off-by: Ben Dooks <ben.dooks@xxxxxxxxxxxxxxx>
> ---
> drivers/firmware/efi/libstub/fdt.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>

Queued up in efi/next - thanks.