Re: [PATCH v10 2/3] crypto: ti - Add support for AES-GCM in DTHEv2 driver

[T Pratham]

On 11/03/26 09:46, Herbert Xu wrote:
> On Tue, Mar 10, 2026 at 10:35:15PM +0530, T Pratham wrote:
>>
>> What potential issue do you see? Both `dthe_aead_prep_src` and
>> `dthe_prep_aead_dst` functions use `sg_split`, which anyway allocates a
>> new scatterlist. Even if req->src == req->dst, the src and dst from here
>> on will be different.
> 
> The copied SG list will still point to the original memroy, right?
> In that case you will end up DMA mapping the same region twice, once
> as input and once as output.  I don't think that's guaranteed to
> work, as you're supposed to map it once as BIDIRECTIONAL.
> 
> Cheers,

Oh, my bad. I though mapping only looked at the sg list for direction.
Will update accordingly.

-- 
Regards
T Pratham <t-pratham@xxxxxx>