Re: [PATCH v6 18/34] gpu: nova-core: Hopper/Blackwell: add FSP message infrastructure
From: Timur Tabi
Date: Wed Mar 11 2026 - 13:54:07 EST
On Tue, 2026-03-10 at 19:57 +0900, Alexandre Courbot wrote:
> > +// Helper function to read FSP boot completion status from the correct register
> > +#[expect(unused)]
> > +pub(crate) fn read_fsp_boot_complete_status(
> > + bar: &crate::driver::Bar0,
> > + arch: Architecture,
> > +) -> Result<u32> {
> > + let addr = fsp_thermal_scratch_reg_addr(arch)?;
> > + Ok(bar.read32(addr))
> > +}
>
> This function is unused, and modified in patch 22 - so let's just move
> its definition to patch 22.
Wouldn't it be better to actually use the function, so that we can verify successful FSP boot?