Re: [PATCH v5 00/10] media: rcar: Streams support

[Tomi Valkeinen]

Hi,

On 11/03/2026 19:38, Niklas Söderlund wrote:
> Hi Tomi,
> 
> Thanks for your work.
> 
> On 2026-03-11 15:53:13 +0200, Tomi Valkeinen wrote:
>> Add streams support to Renesas rcar platform driver.
>>
>> The series keaps compatibility with the current upstream for a single
>> stream use case. However, in upstream there's a limited custom
>> multi-stream support implemented to the rcar driver, which will be
>> replaced with the upstream's Streams API.
>>
>> I have tested this series on Sparrow-Hawk board, with a few different
>> setups:
>>
>> IMX219 connected to the CSI0 connector
>> - The following patches applied to my test branch in addition to this
>>   series:
>>   1) The v4l2_subdev_get_frame_desc_passthrough dependency
>>   2) Revert of commit e7376745ad5c8548e31d9ea58adfb5a847e017a4 ("media:
>>      rcar-vin: Fix stride setting for RAW8 formats"), as that commit
>>      breaks RAW8
> 
> Is this still needed, was this not fixed by "[PATCH] media: renesas: 
> vin: Fix RAW8 (again)" ?

Indeed, not needed, the "Fix RAW8 (again)" solves it.

 Tomi

> 
>> - Tested with a single video stream
>>
>> IMX219 connected to the CSI0 connector
>> - Plenty of other patches applied to enable full streams support and
>>   embedded data support in imx219 and v4l2 framework
>> - Tested with video and embedded data streams
>>  
>> Arducam FPD-Link board + 4 x IMX219 connected to the CSI0 connector
>> - Plenty of other patches applied to enable full streams support and
>>   embedded data support in imx219 and v4l2 framework, and TPG support in
>>   ub953
>> - Tested with video and embedded data streams from all four cameras (so
>>   8 streams in total)
>> - Also tested with ub953's TPG, combined with video & embedded streams
>>   from other cameras.
>>
>> I have observed one issue with the embedded data (i.e. requiring bunch
>> of patches not in upstream): when stopping streaming, VIN says that it
>> cannot stop the stream. I haven't debugged that, but a possible issue is
>> that the if the video stream for the imx219 is stopped first, the
>> embedded data stops also, and VIN does not get the frame-end it is
>> waiting for.
>>
>>  Tomi
>>
>> Signed-off-by: Tomi Valkeinen <tomi.valkeinen+renesas@xxxxxxxxxxxxxxxx>
>> ---
>> Changes in v5:
>> - Rebase on v7.0-rc2, with the streams preparation series and
>>   get_frame_desc_passthrough series as dependencies
>> - This series is now smaller, as the non-streams parts are in the
>>   streams preparation series
>> - Fix "variable ‘format’ set but not used" warning
>> - Link to v4: https://lore.kernel.org/r/20251216-rcar-streams-v4-0-f28b4831cc67@xxxxxxxxxxxxxxxx
>>
>> Changes in v4:
>> - Rebased on v6.18, with minor conflicts resolved
>> - Improved patch descriptions
>> - Re-ordered the patches a bit to move changes that could be applied
>>   without the full streams support to the beginning of the series
>> - Added "media: rcar-vin: Link VINs on Gen3 to a single channel on each
>>   CSI-2" which removes possibility of wrong routing config on Gen3
>> - Added "media: rcar-csi2: Improve FLD_FLD_EN macros" which was part of
>>   another patch in v3
>> - Addressed minor comments (constifyings, cosmetics)
>> - Fixed the missing stream_count checks in disable_streams ops
>> - Fixed a few instances in csisp and csi2 where
>>   v4l2_subdev_state_get_format() was called with hardcoded pad/stream,
>>   instead of using the data from the route
>> - Dropped unnecessary ISPPROCMODE_DT_REG register clears
>> - Squashed "media: rcar-csi2: Add more stream support to
>>   rcsi2_calc_mbps()" into a previous patch
>> - Dropped wrong use_isp check from csi2's rcsi2_set_routing()
>> - Link to v3: https://lore.kernel.org/r/20250530-rcar-streams-v3-0-026655df7138@xxxxxxxxxxxxxxxx
>>
>> Changes in v3:
>> - Rebased on top of latest linux-media
>> - Dropped dependencies which are already in linux-media (only remaining
>>   dependency is v4l2_subdev_get_frame_desc_passthrough)
>> - Tested on white-hawk board, using the staging deser TPG
>> - Also tested in a WIP branch for GMSL2 (two video streams)
>> - Link to v2: https://lore.kernel.org/r/20250326-rcar-streams-v2-0-d0d7002c641f@xxxxxxxxxxxxxxxx
>>
>> Changes in v2:
>> - Rebased on top of latest upstream, and updated the dependencies to
>>   match the latest serieses sent.
>> - Add new patch "media: rcar-csi2: Use the pad version of v4l2_get_link_freq()"
>> - Drop "media: rcar-csi2: Fix typo" (it was not a typo)
>> - Update the code in calc_mbps(). The previous method relied on
>>   V4L2_CID_LINK_FREQ, but that's not available if the link-freq is
>>   provided via get_mbus_config().
>> - Dropped dependencies to Niklas' old series which doesn't apply
>>   cleanly. It's needed for multi-stream, but not for the current
>>   upstream which only has a single stream use case.
>> - Link to v1: https://lore.kernel.org/r/20250219-rcar-streams-v1-0-f1b93e370aab@xxxxxxxxxxxxxxxx
>>
>> ---
>> Tomi Valkeinen (10):
>>       media: rcar-vin: Link VINs on Gen3 to a single channel on each CSI-2
>>       media: rcar-isp: Move {enable|disable}_streams() calls
>>       media: rcar-csi2: Move {enable|disable}_streams() calls
>>       media: rcar-csi2: Switch to Streams API
>>       media: rcar-isp: Switch to Streams API
>>       media: rcar-csi2: Add .get_frame_desc op
>>       media: rcar-isp: Call get_frame_desc to find out VC & DT
>>       media: rcar-csi2: Call get_frame_desc to find out VC & DT (Gen3)
>>       media: rcar-csi2: Add full streams support
>>       media: rcar-isp: Add full streams support
>>
>>  drivers/media/platform/renesas/rcar-csi2.c         | 323 ++++++++++++++++-----
>>  drivers/media/platform/renesas/rcar-isp/csisp.c    | 227 ++++++++++++---
>>  .../media/platform/renesas/rcar-vin/rcar-core.c    |  27 +-
>>  3 files changed, 445 insertions(+), 132 deletions(-)
>> ---
>> base-commit: 9fad1d148df6f36105159c2503d0ecb1397bc89a
>> change-id: 20250219-rcar-streams-1fdea8860e5e
>> prerequisite-change-id: 20260115-rcar-streams-prep-1-1cc285538848:v1
>> prerequisite-patch-id: 78155acff7a40c74881accca6d9699476405e937
>> prerequisite-patch-id: 983b909c5d3667711baf2112713eac7862e5f9e7
>> prerequisite-patch-id: 6dba98cf21fb95029009733448075ee0380eaf16
>> prerequisite-patch-id: db9ed82262cd02a2cb6941dc30f731b6b7c4410c
>> prerequisite-patch-id: 2342bc950678d13b5aa41b2faa276ad1c0e3d850
>> prerequisite-change-id: 20250218-frame-desc-passthrough-66805e413974:v5
>> prerequisite-patch-id: 4b1733536cdc5b2bdd3c996032273c576228da72
>> prerequisite-patch-id: 69b75e7dad9ced905cb39a72f18bebbf3e8f998a
>> prerequisite-patch-id: 58463f6944c76acd6cf203b14a2836cdb0db2461
>>
>> Best regards,
>> -- 
>> Tomi Valkeinen <tomi.valkeinen+renesas@xxxxxxxxxxxxxxxx>
>>
>