Re: [PATCH 1/5] arm64: dts: imx8mp-tqma8mpql-mba8mpxl-g133han01: Remove compatible from overlay
From: Frank Li
Date: Wed Mar 11 2026 - 14:59:47 EST
On Wed, Mar 11, 2026 at 05:49:23PM +0100, Alexander Stein wrote:
> Hi,
>
> Am Mittwoch, 11. März 2026, 17:19:37 CET schrieb Frank Li:
> > On Wed, Mar 11, 2026 at 03:52:15PM +0100, Alexander Stein wrote:
> > > There is no reason to override the board compatible in a an overlay,
> > > remove it. While at it, update the copyright year.
> >
> > Any bad things happen if overwrite in overlay file?
>
> You might override the board compatible when it is set (differently) in
> the mainboard.
Is below better
"Override the board compatible is unexpected, especially when the same dtso
override difference mainboard. So remove it and update the copyright year."
Frank
>
> Best regards,
> Alexander
>
> > Frank
> >
> > >
> > > Signed-off-by: Alexander Stein <alexander.stein@xxxxxxxxxxxxxxx>
> > > ---
> > > .../freescale/imx8mp-tqma8mpql-mba8mpxl-lvds-g133han01.dtso | 6 +-----
> > > 1 file changed, 1 insertion(+), 5 deletions(-)
> > >
> > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl-lvds-g133han01.dtso b/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl-lvds-g133han01.dtso
> > > index 5058cd9409c75..129b02a69ccf0 100644
> > > --- a/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl-lvds-g133han01.dtso
> > > +++ b/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl-lvds-g133han01.dtso
> > > @@ -1,6 +1,6 @@
> > > // SPDX-License-Identifier: (GPL-2.0-or-later OR MIT)
> > > /*
> > > - * Copyright (c) 2023 TQ-Systems GmbH <linux@xxxxxxxxxxxxxxx>,
> > > + * Copyright (c) 2023-2026 TQ-Systems GmbH <linux@xxxxxxxxxxxxxxx>,
> > > * D-82229 Seefeld, Germany.
> > > * Author: Alexander Stein
> > > */
> > > @@ -10,10 +10,6 @@
> > >
> > > #include <dt-bindings/clock/imx8mp-clock.h>
> > >
> > > -&{/} {
> > > - compatible = "tq,imx8mp-tqma8mpql-mba8mpxl", "tq,imx8mp-tqma8mpql", "fsl,imx8mp";
> > > -};
> > > -
> > > &backlight_lvds {
> > > status = "okay";
> > > };
> > > --
> > > 2.43.0
> > >
> >
>
>
> --
> TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
> Amtsgericht München, HRB 105018
> Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
> http://www.tq-group.com/
>
>