Re: [PATCH v8 1/5] net: stmmac: Use helper macro for loop over queue-based arrays

From: Jan Petrous

Date: Thu Mar 12 2026 - 03:50:34 EST


On Wed, Mar 11, 2026 at 08:37:07PM -0700, Jakub Kicinski wrote:
> On Mon, 09 Mar 2026 18:55:20 +0100 Jan Petrous via B4 Relay wrote:
> > The stmmac driver contains similar pattern for processing queue-based
> > arrays, ie. interrupt lines, etc. Factor out the for loop and provide
> > a macro STMMAC_FOREACH_MTL_QUEUE(var, limit).
>
> This is macro is neither shorter nor more readable.
> I really don't see any benefit here..

TBH me neither. Or, I see only "descriptive" benefit, what, of course,
is nothing must-to-have.

I will prepare v11 without this.

Thanks.
/Jan