Re: [PATCH v3 2/3] drm: panel: Add Samsung S6E8FCO DSI controller for M1906F9 panel

[David Heidelberg]

On 12/03/2026 12:55, Yedaya Katsman wrote:
> Add driver for Samsung S6E8FCO DSI controller for M1906F9 video mode panel,
> found in Xiaomi Mi A3 mobile phone.
>
> Co-developed-by: Kamil Gołda <kamil.golda@xxxxxxxxxxxxxx>
> Signed-off-by: Kamil Gołda <kamil.golda@xxxxxxxxxxxxxx>
> Signed-off-by: Yedaya Katsman <yedaya.ka@xxxxxxxxx>
> ---
>   MAINTAINERS                                        |   1 +
>   drivers/gpu/drm/panel/Kconfig                      |  13 +
>   drivers/gpu/drm/panel/Makefile                     |   1 +
>   .../gpu/drm/panel/panel-samsung-s6e8fco-m1906f9.c  | 302 +++++++++++++++++++++
>   4 files changed, 317 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index d7aee8dab903cd42c245fea3cf8971dcd99b2196..d00775a09445a8a1bd626ecfd27903471d08d33a 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -8187,6 +8187,7 @@ DRM DRIVER FOR SAMSUNG S6E8FCO PANELS
>   M:	Yedaya Katsman <yedaya.ka@xxxxxxxxx>
>   S:	Maintained
>   F:	Documentation/devicetree/bindings/display/panel/samsung,s6e8fco-m1906f9.yaml
> +F:	drivers/gpu/drm/panel/panel-samsung-s6e8fco-m1906f9.c
>   
>   DRM DRIVER FOR SAMSUNG SOFEF00 DDIC
>   M:	David Heidelberg <david@xxxxxxx>
> diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
> index 7a83804fedca1b688ce6fbe4295ec9009007e693..ee9cc6939f2ac1dc4542563fd73f68ac5f9ee371 100644
> --- a/drivers/gpu/drm/panel/Kconfig
> +++ b/drivers/gpu/drm/panel/Kconfig
> @@ -893,6 +893,19 @@ config DRM_PANEL_SAMSUNG_S6E8AA5X01_AMS561RA01
>   	  ~5.6 inch AMOLED display, and the controller is driven by the MIPI
>   	  DSI protocol with 4 lanes.
>   
> +config DRM_PANEL_SAMSUNG_S6E8FCO_M1906F9
> +	tristate "Samsung M1906F9 panel with S6E8FCO DSI controller"
> +	depends on OF
> +	depends on BACKLIGHT_CLASS_DEVICE
> +	select DRM_MIPI_DSI
> +	select VIDEOMODE_HELPERS

one more small nit - please double check you need VIDEOMODE_HELPERS

David

[...]
--
David Heidelberg