Re: [PATCH net-next] net: macb: set default_an_inband to true for SGMII

[Charles Perry]

On Thu, Mar 12, 2026 at 03:01:39PM +0000, Conor Dooley wrote:
> On Thu, Mar 12, 2026 at 06:38:55AM -0700, Charles Perry wrote:
> > Most platforms using GEM in SGMII mode use in-band autonegotiation
> > because it is on by default in GEM's 1G PCS and is always on since
> > commit e276e5e40e92 ("net: macb: Disable PCS auto-negotiation for SGMII
> > fixed-link mode"). Leave it on if possible using the "default_an_inband"
> > flag of "struct phylink_config" so that platforms that lack in-band
> > autonegotiation configurability at the PHY do not break with commit
> > 1338cfef1ff1 ("net: macb: fix SGMII with inband aneg disabled") which
> > will turn off in-band autoneg for non hot pluggable PHYs.
> > 
> > Once the majority of the PHY drivers that support SGMII have the
> > ->config_inband() callback, this commit could be reverted so that non
> > hot pluggable PHY use outband negotiation with macb, like its the case
> > for other MACs.
> > 
> > Fixes: 1338cfef1ff1 ("net: macb: fix SGMII with inband aneg disabled")
> > Closes: https://lore.kernel.org/r/20260304-nebulizer-rounding-40fbc81a2ba1@spud
> 
> Reported-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
> 
> > Tested-by: Conor Dooley <conor@xxxxxxxxxx>
> 
> Just as an FYI, you shouldn't insert tags that "certify" the quality of
> your patch that you weren't explicitly given. Reported-by/Suggested-by
> you can conjure up yourself where appropriate, but Tested-by/Acked-by/Reviewed-by
> need more care.
> 

Ok, thank you for pointing this out.

> But of course, I did test it, and it restored functionality on both
> boards that I have here, so:
> Tested-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
> 

Thanks,
Charles