Re: [PATCH v5 2/6] cpufreq: Add boost_freq_req QoS request

[Viresh Kumar]

On 11-03-26, 14:52, Rafael J. Wysocki wrote:
> On Wed, Feb 25, 2026 at 9:49 AM Pierre Gondois <pierre.gondois@xxxxxxx> wrote:
> > -       if (policy->max_freq_req) {
> > +       if ((policy->max_freq_req && !policy->boost_supported) ||
> > +           policy->boost_freq_req) {
> 
> Are you sure?

Its messy for sure, but looks okay. We register CPUFREQ_REMOVE_POLICY when:
- max-freq-req is set and boost isn't supported
- or if boost is supported, then boost-freq-req must be set as well.

> Instead of doing this, why don't you add 1 to the policy->min_freq_req
> allocation size when boost is supported?  You'll destroy the policy if
> the allocation fails anyway.

+1

-- 
viresh