Re: [PATCH v4 2/5] platform: arm64: Add driver for EC found on Qualcomm reference devices

From: Anvesh Jain P

Date: Fri Mar 13 2026 - 10:21:33 EST




On 3/13/2026 5:47 PM, Bryan O'Donoghue wrote:
> On 13/03/2026 10:29, Anvesh Jain P wrote:
>> + * Read Response:
>> + *
>> ----------------------------------------------------------------------
>> + * | Offset    | Name        | Description                |
>> + *
>> ----------------------------------------------------------------------
>> + * | 0x00    | Byte count    | Number of bytes in response        |
>> + * |        |        | (exluding byte count)            |
>
> Great to see this documented in the code.
>
> Please run checkpatch and take heed of what it says.
>
> 0002-platform-arm64-Add-driver-for-EC-found-on-Qualcomm-r.patch has no
> obvious style problems and is ready for submission.
> 0002-platform-arm64-Add-driver-for-EC-found-on-Qualcomm-r.patch:184:
> exluding ==> excluding, exuding
> 0002-platform-arm64-Add-driver-for-EC-found-on-Qualcomm-r.patch:224:
> exluding ==> excluding, exuding
> total: 0 errors, 0 warnings, 0 checks, 28 lines checked

Thanks for the review! Confirmed the typo — will fix both occurrences in
the next revision of the patch series.

>
> ---
> bod

Best regards,
Anvesh