Re: [PATCH 1/2] pinctrl: spacemit: return -ENOTSUPP for unsupported pin configurations

From: Bartosz Golaszewski

Date: Fri Mar 13 2026 - 10:23:09 EST


On Thu, Mar 12, 2026 at 9:43 AM Junhui Liu <junhui.liu@xxxxxxxxxxxxx> wrote:
>
> Return -ENOTSUPP instead of -EINVAL when encountering unsupported pin
> configuration parameters. This is more logical and allows the GPIO
> subsystem to gracefully handle unsupported parameters via functions like
> gpio_set_config_with_argument_optional(), which specifically ignores
> -ENOTSUPP but treats others as failure.
>
> Signed-off-by: Junhui Liu <junhui.liu@xxxxxxxxxxxxx>
> ---

Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxxxxxxxx>