[PATCH] media: subdev: Fix error pointer dereference
From: Ethan Tidmore
Date: Fri Mar 13 2026 - 23:03:04 EST
The function media_pad_remote_pad_unique() returns an error pointer upon
failure, not null.
Add check for error pointer and extract the error code with PTR_ERR().
Fixes: a564839e630c1 ("media: subdev: Add v4l2_subdev_get_frame_desc_passthrough helper")
Signed-off-by: Ethan Tidmore <ethantidmore06@xxxxxxxxx>
---
drivers/media/v4l2-core/v4l2-subdev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/v4l2-core/v4l2-subdev.c b/drivers/media/v4l2-core/v4l2-subdev.c
index 9efd14d4026f..7cb17e0a5617 100644
--- a/drivers/media/v4l2-core/v4l2-subdev.c
+++ b/drivers/media/v4l2-core/v4l2-subdev.c
@@ -2585,10 +2585,10 @@ int v4l2_subdev_get_frame_desc_passthrough(struct v4l2_subdev *sd,
if (!have_source_fd) {
remote_source_pad = media_pad_remote_pad_unique(local_sink_pad);
- if (!remote_source_pad) {
+ if (IS_ERR(remote_source_pad)) {
dev_dbg(dev, "Failed to find remote pad for sink pad %u\n",
local_sink_pad->index);
- ret = -EINVAL;
+ ret = PTR_ERR(remote_source_pad);
goto out_unlock;
}
--
2.53.0