Re: [PATCH v3 0/2] iio: proximity: add driver for ST VL53L1X ToF sensor

[Jonathan Cameron]

On Sat, 14 Mar 2026 21:25:44 +0600
Sirat <email@xxxxxxxx> wrote:

> On Sat, Mar 14, 2026 at 8:39 PM David Lechner <dlechner@xxxxxxxxxxxx> wrote:
> >
> > On 3/12/26 10:12 AM, Sirat wrote:  
> > > On Thu, Mar 12, 2026 at 8:28 PM Andy Shevchenko
> > > <andriy.shevchenko@xxxxxxxxx> wrote:  
> > >>
> > >> On Thu, Mar 12, 2026 at 04:40:35AM +0600, Siratul Islam wrote:  
> > > ...  
> > >>> ---
> > >>> Changes in v3:
> > >>> - Merge DT binding into existing st,vl53l0x.yaml (per Krzysztof).
> > >>> - Use "reset-gpios" in the binding but xshut_gpio in the driver since that's the actual pin name.  
> > >>  
> >
> > We can modify the existing binding to make the supply required based
> > on the compatible.
> >
> > allOf:
> >   # Technically supply is required to power device, but we keep it
> >   # optional for "st,vl53l0x" for backwards compatibility.
> >   - if:
> >       not:
> >         properties:
> >           compatible:
> >             const: "st,vl53l0x"
> >     then:
> >       required:
> >         vdd-supply
> >
> >
> > And we can add a description to reset-gpios to explain that it is actually the
> > XSHUT pin.
> >  
> This will solve the problem, but I'm concerned about someone not
> following the commit history looking at the code.
> Logically, it doesn't make sense as both the devices require the
> supply. In fact it may give the impression that
> the vl53l0x explicitly doesn't need power. We are having to deal with
> too much just to save us from writing a new file.
> 
> That said, I can still implement this if it's still the prefered way
> to solve our problem. Or leave it optional as it is.
> >  
Can make it required in the binding. Just explain clearly why
it should be there.  The driver should carry on coping without
it though (and leave a comment so we don't break that in the future).

Jonathan

>