Re: [PATCH v2 1/6] media: vidtv: Rename PI definition to PI_SAMPLES

[Andy Shevchenko]

On Mon, Mar 16, 2026 at 11:13:24AM +0100, Hans Verkuil wrote:
> 
> Just FYI: I'll take this patch. Regardless of the other patches in this series it does
> make sense.

Thank you!

> I haven't seen any updates to this series, is it abandoned?

There is no consensus which names should be chosen. I have strong opinion about
my choice, some do not agree with. Id est I like the idea to have PI as PI and
not something longer and confusing. Same for 64-bit, just some short.

My rationale is that, in most of the cases the 32-bit value will be used and
having it as is would be nice.

Another point is to have a macro that gives PI rounded to the chosen amount of
digits (to avoid / 10 / 100 / et cetera in the users). I don't know how to
implement that nicely, there is no loops or alike in C preprocessor.

-- 
With Best Regards,
Andy Shevchenko