Re: [PATCH v13 RESEND 03/14] arm64/ptrace: Expand secure_computing() in place

[Linus Walleij]

On Tue, Mar 17, 2026 at 9:20 AM Jinjie Ruan <ruanjinjie@xxxxxxxxxx> wrote:

> Refactor syscall_trace_enter() by open-coding the seccomp check
> to align with the generic entry framework.
>
> [Background]
> The generic entry implementation expands the seccomp check in-place
> instead of using the secure_computing() wrapper. It directly tests
> SYSCALL_WORK_SECCOMP and calls the underlying __secure_computing()
> function to handle syscall filtering.
>
> [Changes]
> 1. Open-code seccomp check:
>    - Instead of calling the secure_computing() wrapper, explicitly check
>      the 'flags' parameter for _TIF_SECCOMP.
>    - Call __secure_computing() directly if the flag is set.
>
> 2. Refine return value handling:
>    - Use 'return ret ? : syscall' to propagate the return value.
>    - Ensures any unexpected non-zero return from __secure_computing()
>      is properly propagated is properly propagated.
>    - This matches the logic in the generic entry code.
>
> [Why this matters]
> - Aligns the arm64 syscall path with the generic entry implementation,
>   simplifying future migration to the generic entry framework.
> - No functional changes are intended; seccomp behavior remains identical.
>
> Cc: Will Deacon <will@xxxxxxxxxx>
> Cc: Catalin Marinas <catalin.marinas@xxxxxxx>
> Reviewed-by: Kevin Brodsky <kevin.brodsky@xxxxxxx>
> Signed-off-by: Jinjie Ruan <ruanjinjie@xxxxxxxxxx>

Reviewed-by: Linus Walleij <linusw@xxxxxxxxxx>

Yours,
Linus Walleij