Re: [PATCH 4/6] platform/x86/intel/pmc: Add support for variable DMU offsets

[Ilpo Järvinen]

On Mon, 2 Mar 2026, Xi Pardee wrote:

> Add support for handling different DMU Die C6 offsets across platforms.
> The previous implementation assumed a uniform DMU Die C6 offset for all
> platforms, which is no longer valid.
> 
> Signed-off-by: Xi Pardee <xi.pardee@xxxxxxxxxxxxxxx>
> ---
>  drivers/platform/x86/intel/pmc/arl.c  | 2 ++
>  drivers/platform/x86/intel/pmc/core.c | 2 +-
>  drivers/platform/x86/intel/pmc/core.h | 2 ++
>  drivers/platform/x86/intel/pmc/mtl.c  | 1 +
>  4 files changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/intel/pmc/arl.c b/drivers/platform/x86/intel/pmc/arl.c
> index 95372a0807acf..4d91ee010f6d0 100644
> --- a/drivers/platform/x86/intel/pmc/arl.c
> +++ b/drivers/platform/x86/intel/pmc/arl.c
> @@ -729,6 +729,7 @@ struct pmc_dev_info arl_pmc_dev = {
>  	.init = arl_core_init,
>  	.sub_req = pmc_core_pmt_get_lpm_req,
>  	.ssram_hidden = true,
> +	.die_c6_offset = MTL_PMT_DMU_DIE_C6_OFFSET,
>  };
>  
>  static u32 ARL_H_PMT_DMU_GUIDS[] = {ARL_PMT_DMU_GUID, ARL_H_PMT_DMU_GUID, 0x0};
> @@ -742,4 +743,5 @@ struct pmc_dev_info arl_h_pmc_dev = {
>  	.init = arl_h_core_init,
>  	.sub_req = pmc_core_pmt_get_lpm_req,
>  	.ssram_hidden = true,
> +	.die_c6_offset = MTL_PMT_DMU_DIE_C6_OFFSET,
>  };
> diff --git a/drivers/platform/x86/intel/pmc/core.c b/drivers/platform/x86/intel/pmc/core.c
> index 7670970c995b9..7bd0e1eaa32e2 100644
> --- a/drivers/platform/x86/intel/pmc/core.c
> +++ b/drivers/platform/x86/intel/pmc/core.c
> @@ -1387,7 +1387,7 @@ void pmc_core_punit_pmt_init(struct pmc_dev *pmcdev, struct pmc_dev_info *pmc_de
>  		}
>  
>  		pmcdev->punit_ep = ep;
> -		pmcdev->die_c6_offset = MTL_PMT_DMU_DIE_C6_OFFSET;
> +		pmcdev->die_c6_offset = pmc_dev_info->die_c6_offset;
>  	}
>  
>  	if (pmc_dev_info->pc_guid) {
> diff --git a/drivers/platform/x86/intel/pmc/core.h b/drivers/platform/x86/intel/pmc/core.h
> index 31fe71b01120b..f09791f866223 100644
> --- a/drivers/platform/x86/intel/pmc/core.h
> +++ b/drivers/platform/x86/intel/pmc/core.h
> @@ -514,6 +514,7 @@ enum pmc_index {
>   * @init:		Function to perform platform specific init action
>   * @sub_req:		Function to achieve low power mode substate requirements
>   * @ssram_hidden:	Flag to indicate whether SSRAM is hidden
> + * @die_c6_offseyt:	Telemetry offset to read Die C6 residency

Typo (-t)

>   */
>  struct pmc_dev_info {
>  	u32 *dmu_guids;
> @@ -530,6 +531,7 @@ struct pmc_dev_info {
>  	int (*init)(struct pmc_dev *pmcdev, struct pmc_dev_info *pmc_dev_info);
>  	int (*sub_req)(struct pmc_dev *pmcdev, struct pmc *pmc, struct telem_endpoint *ep);
>  	bool ssram_hidden;
> +	u32 die_c6_offset;
>  };
>  
>  extern const struct pmc_bit_map msr_map[];
> diff --git a/drivers/platform/x86/intel/pmc/mtl.c b/drivers/platform/x86/intel/pmc/mtl.c
> index 193ebbe584023..b724dd8c34dba 100644
> --- a/drivers/platform/x86/intel/pmc/mtl.c
> +++ b/drivers/platform/x86/intel/pmc/mtl.c
> @@ -1003,4 +1003,5 @@ struct pmc_dev_info mtl_pmc_dev = {
>  	.init = mtl_core_init,
>  	.sub_req = pmc_core_pmt_get_lpm_req,
>  	.ssram_hidden = true,
> +	.die_c6_offset = MTL_PMT_DMU_DIE_C6_OFFSET,
>  };
> 

-- 
 i.