Re: [PATCH net-next v3 2/2] r8152: Add support for the RTL8157 hardware
From: Paolo Abeni
Date: Tue Mar 24 2026 - 06:59:59 EST
On 3/20/26 12:14 PM, Birger Koblitz wrote:
> @@ -2022,14 +2277,14 @@ static void intr_callback(struct urb *urb)
> }
> }
>
> -static inline void *rx_agg_align(void *data)
> +static inline void *rx_agg_align(struct r8152 *tp, void *data)
> {
> - return (void *)ALIGN((uintptr_t)data, RX_ALIGN);
> + return (void *)ALIGN((uintptr_t)data, tp->rx_desc.align);
> }
>
> -static inline void *tx_agg_align(void *data)
> +static inline void *tx_agg_align(struct r8152 *tp, void *data)
Since you are touching this functions, in the next revision please
additionally drop the 'inline' keyword; the compiler should be good
enough to get them inlined anyway.
/P