Re: [net-next,v3,1/2] r8152: Add support for 5Gbit Link Speeds and EEE

[Birger Koblitz]

Hi Paolo,

thanks for reviewing the patch.
On 24/03/2026 11:55 am, Paolo Abeni wrote:
> The new NWAY_5000M_FULL falls through to 'default: break;', which means
> ups_flags_speed() is never called. This results in incorrect UPS flags
> (speed bits = 0) being written to the USB_UPS_FLAGS hardware register via
> ocp_write_dword().
>
> When the device enters UPS power saving mode at 5000M link speed, will the
> hardware receive correct speed information?
>
> The follow-up commit defca1127dd51 ('r8152: Add support for the RTL8157
> hardware') enables support_5000full for RTL_VER_16 but also does not add a
> NWAY_5000M_FULL case to r8156_ups_flags().

The exact same point was raised before:
https://lkml.org/lkml/2026/3/19/1765
it was answered by me here: https://lkml.org/lkml/2026/3/20/242 and
the answer was accepted here: https://lkml.org/lkml/2026/3/20/464

B.