Re: [PATCH RESEND 3/3] lib: Fix length calculation in extract_kvec_to_sg

From: Andrew Morton

Date: Tue Mar 24 2026 - 16:11:55 EST


On Tue, 24 Mar 2026 20:47:01 +0100 "Christian A. Ehrhardt" <lk@xxxxxxx> wrote:

>
> Hi Andrew,
>
> On Tue, Mar 24, 2026 at 12:15:52PM -0700, Andrew Morton wrote:
> > On Mon, 23 Mar 2026 22:23:50 +0100 "Christian A. Ehrhardt" <lk@xxxxxxx> wrote:
> >
> > > When extracting from a kvec to a scatterlist, do not
> > > cross page boundaries. The required length is already
> > > calculated but not used as intended.
> > >
> > > The previous changes to the kunit_iov_iter.c demonstrate
> > > that the patch is necessary.
> > >
> > > Cc: David Howells <dhowells@xxxxxxxxxx>
> > > Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> > > Cc: stable@xxxxxxxxxxxxxxx # v6.5+
> >
> > But 018584697533 was first released in 6.10?
>
> No, it was first in 6.3:
> | $ git log v6.3 | grep -A3 "commit 018584697533"
> | commit 0185846975339a5c348373aa450a977f5242366b
> | Author: David Howells <dhowells@xxxxxxxxxx>
> | Date: Thu Oct 27 16:19:44 2022 +0100

hp2:/usr/src/mm> git show --pretty=fuller 018584697533 | head -n10
commit 0185846975339a5c348373aa450a977f5242366b
Author: David Howells <dhowells@xxxxxxxxxx>
AuthorDate: Thu Oct 27 16:19:44 2022 +0100
Commit: Steve French <stfrench@xxxxxxxxxxxxx>
CommitDate: Mon Feb 20 17:25:43 2023 -0600

It obviously got stalled somewhere for a while.

>
> > I'll remove the " v6.5+" - it isn't needed when we have the Fixes: hash.
>
> Please don't. The patch will only apply without modification
> for v6.5+ because the function was moved to a different file.
> As the only stable kernels in that range are 6.1 and 6.6 the
> v6.5+ should be sufficient?

hp2:/usr/src/mm> git tag --contains 018584697533 | grep "^v[0-9]*" | head
v6.10
v6.10-rc1
v6.10-rc2
v6.10-rc3
v6.10-rc4
v6.10-rc5
v6.10-rc6
v6.10-rc7
v6.11

> > But please do check that 018584697533 was the correct target.
>
> It is, see above.
>
> I have an updated verion of the series almost ready that addresses
> some of the AI review comments. Should I send an updated version or
> incremental patches?

A new series will work, thanks.