RE: [PATCH v4 3/4] iio: adc: ad4691: add triggered buffer support

From: Sabau, Radu bogdan

Date: Wed Mar 25 2026 - 09:36:19 EST




> -----Original Message-----
> From: Nuno Sá <noname.nuno@xxxxxxxxx>
> Sent: Tuesday, March 24, 2026 2:23 PM

...

> > +static int ad4691_cnv_burst_buffer_postdisable(struct iio_dev *indio_dev)
> > +{
> > + struct ad4691_state *st = iio_priv(indio_dev);
> > + struct device *dev = regmap_get_device(st->regmap);
> > + int ret;
> > +
> > + disable_irq(st->irq);
>
> Should we use disable_irq_sync()?

Isn't disable_irq() already calling synchronize_irq() inside it? I can't see
disable_irq_sync() in the current kernel, only disable_irq_nosync().

> > +
> > + ret = ad4691_sampling_enable(st, false);
> > + if (ret)
> > + return ret;
> > +