Re: [PATCH v6 1/4] dt-bindings: usb: Add binding for Genesys Logic GL3590 hub

[Swati Agarwal]

On Wed, Mar 18, 2026 at 12:31 PM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
>
> On Wed, Mar 18, 2026 at 09:36:41AM +0530, Swati Agarwal wrote:
>
> A nit, subject: drop second/last, redundant "binding fir". The
> "dt-bindings" prefix is already stating that these are bindings.
> See also:
> https://elixir.bootlin.com/linux/v6.17-rc3/source/Documentation/devicetree/bindings/submitting-patches.rst#L18
>
> >    reg: true
> > @@ -26,6 +27,10 @@ properties:
> >      description:
> >        The regulator that provides 3.3V or 5.0V core power to the hub.
> >
> > +  vdd12-supply:
> > +    description:
> > +      The regulator that provides 1.2V power to the hub.
> > +
> >    peer-hub: true
> >
> >    ports:
> > @@ -69,6 +74,17 @@ allOf:
> >          peer-hub: true
> >          vdd-supply: true
>
> Here and in other cases you forgot to forbid new property (: false).
Hi Krysztof,
My v5 patch series address this thing as follows:-
https://lore.kernel.org/all/20260122092852.887624-2-swati.agarwal@xxxxxxxxxxxxxxxx/

But as per feedback from Rob on v4 and v5 series, i address it as per
his comment.

https://lore.kernel.org/all/20260122170651.GA2632938-robh@xxxxxxxxxx/#t
https://lore.kernel.org/all/20260121022449.GA1804139-robh@xxxxxxxxxx/#t

Let me know how we should proceed further on this @Rob Herring
@Krzysztof Kozlowski .

Regards,
Swati