Re: [PATCH v1 0/2] platform/x86/intel-uncore-freq: Expose instance ID in the sysfs
From: Maciej Wieczor-Retman
Date: Mon Mar 30 2026 - 04:11:51 EST
On 2026-03-29 at 12:30:59 -0700, srinivas pandruvada wrote:
>On Fri, 2026-03-27 at 21:03 +0000, Maciej Wieczor-Retman wrote:
>> On 2026-03-27 at 19:51:54 +0200, Artem Bityutskiy wrote:
>> > On Fri, 2026-03-27 at 15:36 +0000, Maciej Wieczor-Retman wrote:
>> > > on newer systems that can have multiple clusters on a single die,
>> > > the
>> > > intel-uncore-freq driver behaves differently and the domain_id is
>> > > a
>> > > globally unique value - unique on all TPMI devices. Therefore
>> > > it's
>> > > difficult to match a specific instance to a set of UFS registers
>> > > for
>> > > example visible through /sys/kernel/debug/tpmi directories.
>> >
>> > Although, I'd say that the key point isn't that "domain_id is
>> > globally
>> > unique" (though this is true), but that it's a synthetic value
>> > generated by the driver rather than representing an actual HW
>> > instance
>> > ID.
>> >
>> > Artem.
>>
>> Right, that's worth emphasizing. I'll try to rephrase it when
>> updating the
>> patches.
>
>I think the purpose is not clear. Also need to update the
>documentation.
>Let me write one tomorrow.
>
>Thanks,
>Srinivas
Would it help if the purpose was stated as:
"this domain_id value is not attached to a HW instance ID anymore"
and then I could show the debug tpmi device mem_dump contents and how it
diverges with the domain_id - hence why the instance_id needs to be exported?
--
Kind regards
Maciej Wieczór-Retman