RE: [PATCH v5 2/4] iio: adc: ad4691: add initial driver for AD4691 family
From: Sabau, Radu bogdan
Date: Mon Mar 30 2026 - 10:26:01 EST
> -----Original Message-----
> From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>
> Sent: Friday, March 27, 2026 1:36 PM
> To: Sabau, Radu bogdan <Radu.Sabau@xxxxxxxxxx>
...
>
> > +#include <linux/bitfield.h>
> > +#include <linux/bitops.h>
> > +#include <linux/cleanup.h>
> > +#include <linux/delay.h>
> > +#include <linux/device.h>
>
> Hmm... Is it used? Or perhaps you need only
> dev_printk.h
> device/devres.h
> ?
Hi Andy,
I have checked this out and it seems device.h doesn't actually need
to be included anyway since spi.h directly includes device.h, and since
this is a SPI driver that's never going away, it's covered. Will drop it!
Thanks,
Radu