Re: [PATCH] clk: qcom: videocc-glymur: Constify qcom_cc_desc

[Taniya Das]

On 3/31/2026 2:25 PM, Krzysztof Kozlowski wrote:
> Static 'struct qcom_cc_desc' is not modified by drivers and can be made
> const for code safety.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>
> 
> ---
> 
> Drivers for SM8750 video cc had the same issue. It would be nice if new
> code is being built on top of UPSTREAM code, not downstream.
> ---
>  drivers/clk/qcom/videocc-glymur.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/qcom/videocc-glymur.c b/drivers/clk/qcom/videocc-glymur.c
> index bb3aae6b8396..ea20605dd1e5 100644
> --- a/drivers/clk/qcom/videocc-glymur.c
> +++ b/drivers/clk/qcom/videocc-glymur.c
> @@ -495,7 +495,7 @@ static struct qcom_cc_driver_data video_cc_glymur_driver_data = {
>  	.clk_regs_configure = clk_glymur_regs_configure,
>  };
>  
> -static struct qcom_cc_desc video_cc_glymur_desc = {
> +static const struct qcom_cc_desc video_cc_glymur_desc = {
>  	.config = &video_cc_glymur_regmap_config,
>  	.clks = video_cc_glymur_clocks,
>  	.num_clks = ARRAY_SIZE(video_cc_glymur_clocks),

Reviewed-by: Taniya Das <taniya.das@xxxxxxxxxxxxxxxx>

-- 
Thanks,
Taniya Das