Re: [PATCH phy-fixes] phy: marvell: mvebu-a3700-utmi: fix incorrect USB2_PHY_CTRL register access

[Miquel Raynal]

Hi Gabor,

On 21/03/2026 at 15:42:32 +01, Gabor Juhos <j4g8y7@xxxxxxxxx> wrote:

> The mvebu_a3700_utmi_phy_power_off() function tries to modify the
> USB2_PHY_CTRL register by using the IO address of the PHY IP block along
> with the readl/writel IO accessors. However, the register exist in the
> USB miscellaneous register space, and as such it must be accessed via
> regmap like it is done in the mvebu_a3700_utmi_phy_power_on() function.
>
> Change the code to use regmap_update_bits() for modífying the register

Spurious accent here :-)                             ^

Do you imply that the register access was not working? Or that it was
not using the correct API? (hence potential issues with locking might arise)


Reviewed-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>

Miquèl