Re: [PATCH v4 2/3] leds: flash: rt8515: Support single-GPIO flash ICs with vin supply

From: Linus Walleij

Date: Tue Mar 31 2026 - 14:29:41 EST


On Tue, Mar 31, 2026 at 7:08 PM Rudraksha Gupta via B4 Relay
<devnull+guptarud.gmail.com@xxxxxxxxxx> wrote:

> From: Rudraksha Gupta <guptarud@xxxxxxxxx>
>
> Extend the RT8515 driver to support flash ICs that use only a single
> GPIO for both flash and torch modes (no separate ENT pin), with an
> optional vin regulator that gates power to the flash IC.
>
> When vin-supply is provided, the driver enables the regulator before
> activating the LED and disables it when turning off.
>
> Make ent-gpios optional and validate at probe time that exactly one of
> ent-gpios or vin-supply is provided. When ent-gpios is absent, the
> driver uses enf-gpios for both flash and torch brightness control.
>
> Assisted-by: Claude:claude-opus-4.6
> Signed-off-by: Rudraksha Gupta <guptarud@xxxxxxxxx>

Excellent this looks good to me!
Reviewed-by: Linus Walleij <linusw@xxxxxxxxxx>

Yours,
Linus Walleij