RE: [PATCH v3 3/3] iommu/arm-smmu-v3: Allow ATS to be always on

From: Tian, Kevin

Date: Wed Apr 01 2026 - 04:16:20 EST


> From: Jason Gunthorpe <jgg@xxxxxxxxxx>
> Sent: Tuesday, March 31, 2026 8:08 PM
>
> On Tue, Mar 31, 2026 at 08:40:17AM +0000, Tian, Kevin wrote:
> > > From: Nicolin Chen <nicolinc@xxxxxxxxxx>
> > > Sent: Saturday, March 7, 2026 7:41 AM
> > >
> > > +
> > > + master->ats_always_on = true;
> > > +
> > > + ret = arm_smmu_alloc_cd_tables(master);
> > > + if (ret)
> > > + return ret;
> > > +
> > > +out_prepare:
> > > + pci_prepare_ats(pdev, stu);
> > > + return 0;
> >
> > is there a problem leaving ats_always_on being true while
> > allocating cd tables fails?
>
> I would expect this error flow unwinds back up to failing device
> probe?
>

yeah, I thought error was ignored.

Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx>