Re: [PATCH v9 5/6] reset: rzv2h-usb2phy: Convert to regmap API

[Tommaso Merciai]

Hi Philipp,
Thanks for your comments.

On Wed, Apr 01, 2026 at 11:25:52AM +0200, Philipp Zabel wrote:
> On Mi, 2026-04-01 at 11:10 +0200, Tommaso Merciai wrote:
> [...]
> > 
> > Then we can have:
> > 
> > static const struct reg_sequence rzv2h_init_seq[] = {
> > 	{ .reg = 0xc10, .def = 0x67c },
> > 	{ .reg = 0xc14, .def = 0x01f },
> > 	{ .reg = 0x600, .def = 0x909 },
> > };
> > 
> > static const struct reg_sequence rzv2h_assert_seq[] = {
> > 	{ .reg = 0xb04, .def = 0x303 },
> > 	{ .reg = 0x000, .def = 0x206, .delay_us = 20 },
> 
> This will call fsleep(20), which maps to usleep_range(20, 25).
> Please comment on why the delay is changed in the commit message.

Ouch, thanks.

Reference Manual says:
 - This reset must be asserted for more than 10us.

Then I think the right choiche would be:
	
	.delay_us = 11

This will call fsleep(11) which maps usleep_range(11, 13)
Please correct me if I'm wrong.

Thanks,
Tommaso


> 
> regards
> Philipp