Re: [PATCH v2 0/2] staging: media: atomisp: clean up ISP configuration path
From: Andy Shevchenko
Date: Wed Apr 01 2026 - 09:48:58 EST
On Wed, Apr 1, 2026 at 12:17 AM Jose A. Perez de Azpillaga
<azpijr@xxxxxxxxx> wrote:
>
> NOT TESTED, REVIEW CAREFULLY.
>
> This series cleans up technical debt in the ISP configuration path of
> the AtomISP driver.
>
> Resolves a long-standing FIXME by gating ref and TNR frame configuration
> behind the ISP feature flags that already govern their allocation,
> rather than unconditionally attempting to use frames that may not have
> been built into the pipeline, and removes a duplicate call that
> overwrites the same cached state with identical values.
>
> v2:
> - Replaced NULL checks with feature flag guards to address the root
> cause rather than the symptom.
> - Updated subject line and commit message accordingly in patch 1/2.
> - Expanded commit message to explain why the duplicate call is safe to
> remove in patch 2/2.
> - Updated subject line in patch 2/2.
Actually we don't need "staging:" in the Subject, it makes the lines
unnecessary longer. AtomISPv2 is a unique driver and I'm sure staging
or not we always identify it right. Also check `git log --no-merges
--oneline -- drivers/staging/media/atomisp/`, it shows the common way
of doing that.
--
With Best Regards,
Andy Shevchenko