Re: [PATCH v2 2/2] staging: media: atomisp: remove redundant call to ia_css_output0_configure()
From: Andy Shevchenko
Date: Wed Apr 01 2026 - 10:08:15 EST
On Wed, Apr 1, 2026 at 12:17 AM Jose A. Perez de Azpillaga
<azpijr@xxxxxxxxx> wrote:
>
> The function configure_isp_from_args() contained a duplicate call to
> ia_css_output0_configure() using the same output frame index. Remove the
> redundant call to simplify the configuration path.
>
> The ia_css_output0_configure() function acts as a configuration setter.
> It populates a struct ia_css_output0_configuration from the frame info
> and caches it in the binary parameters. Calling it twice with the same
> out_frame[0] pointer merely overwrites the exact same state with
> identical values. It has no cumulative state, either does its order
neither
> matter relative to ia_css_copy_output_configure().
With fixed subject and detail in the commit message above,
Reviewed-by: Andy Shevchenko <andy@xxxxxxxxxx>
--
With Best Regards,
Andy Shevchenko