Re: [PATCH v2 1/2] dt-bindings: hwmon/pmbus: Add Infineon XDP720

[Krzysztof Kozlowski]

On Wed, Apr 01, 2026 at 04:15:49PM +0530, ASHISH YADAV wrote:
> From: Ashish Yadav <ashish.yadav@xxxxxxxxxxxx>
> 
> Add documentation for the device tree binding of the XDP720 eFuse.
> 
> Signed-off-by: Ashish Yadav <ashish.yadav@xxxxxxxxxxxx>
> ---
> This patch introduces a YAML schema describing the required and optional
> properties for the XDP720 eFuse device node. It includes details on the
> compatible string, register mapping, and rimon-micro-ohms(RIMON).
> 
> The RIMON resistance is installed between the Imon pin and the ground
> reference.

Why are you adding second commit msg? Hardware description goes to
commit msg. Redundant parts go to /dev/null.


> ---
>  .../bindings/hwmon/pmbus/infineon,xdp720.yaml | 51 +++++++++++++++++++
>  1 file changed, 51 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/hwmon/pmbus/infineon,xdp720.yaml
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/infineon,xdp720.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/infineon,xdp720.yaml
> new file mode 100644
> index 000000000000..bbde8ff92ae9
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/pmbus/infineon,xdp720.yaml
> @@ -0,0 +1,51 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +
> +$id: http://devicetree.org/schemas/hwmon/pmbus/infineon,xdp720.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Infineon XDP720 Digital eFuse Controller
> +
> +maintainers:
> +  - Ashish Yadav <ashish.yadav@xxxxxxxxxxxx>
> +
> +description: |
> +  The XDP720 is an eFuse with integrated current sensor and digital
> +  controller. It provides accurate system telemetry (V, I, P, T) and
> +  reports analog current at the IMON pin for post-processing.
> +
> +  Datasheet:
> +     https://www.infineon.com/assets/row/public/documents/24/49/infineon-xdp720-001-datasheet-en.pdf
> +
> +properties:
> +  compatible:
> +    enum:
> +      - infineon,xdp720
> +
> +  reg:
> +    maxItems: 1
> +
> +  infineon,rimon-micro-ohms:
> +    description: |

Do not need '|' unless you need to preserve formatting.

> +      The value of the RIMON resistor, in micro ohms, required to enable
> +      the system overcurrent protection.
> +

Missing supply

> +required:
> +  - compatible
> +  - reg

Here as well, most likely.

Best regards,
Krzysztof