Re: [PATCH 1/3] dt-bindings: clock: qcom: document the Milos GX clock controller
From: Krzysztof Kozlowski
Date: Thu Apr 02 2026 - 04:27:17 EST
On 07/03/2026 16:30, Krzysztof Kozlowski wrote:
>> +
>> +properties:
>> + compatible:
>> + enum:
>> + - qcom,milos-gxclkctl
>> +
>> + power-domains:
>> + description:
>> + Power domains required for the clock controller to operate
>> + items:
>> + - description: GFX power domain
>> + - description: GPUCC(CX) power domain
>> +
>> + '#power-domain-cells':
>> + const: 1
>> +
>> + reg:
>> + maxItems: 1
>
> reg should be the second property, like you have it in "required" part.
> I guess you copied it from kaanapali-gxclkctl.yaml, so lesson - qcom
> bindings have acceptable quality, but not good enough to take as correct
> starting point.
>
OTOH, why this entire binding cannot be squashed in Kaanapali one?
What's the difference?
Best regards,
Krzysztof