Re: [PATCH] ata: pata_arasan_cf: fix missing newline in dev_err messages

[Niklas Cassel]

Hello Haoyu,

On Thu, Apr 02, 2026 at 03:48:42PM +0800, Haoyu Lu wrote:
> Hi Damien,
> 
> Sorry for the mistake!
> I didn't realize libata patches need to be based on libata/for-next,
> not mainline.

This patch was not based on either libata/for-next or Linus's tree.


> I see the driver has been refactored and the newlines are already fixed.
> I'll drop this patch and follow the correct branch for future changes.
> Thanks for the clarification!

There has not been any newlines added upstream, your fix is still valid.

However, the function has not been refactored, you must have based your
patch on some downstream kernel.

While the patch does apply, and I could theoretically apply it, please:

-Send a V2 based on libata/for-next or Linus's tree
-Pick up the tag from Viresh
-Change the subject from
 ata: pata_arasan_cf: fix missing newline in dev_err messages
 to
 ata: pata_arasan_cf: fix missing newline in dev_err() messages


If only to give you experience working with upstream kernels.


Kind regards,
Niklas