Re: [PATCH v2 1/3] arm64: dts: qcom: sdm845-shift-axolotl: Enable sdcard

[David Heidelberg]

On 02/04/2026 11:23, Konrad Dybcio wrote:
> On 4/1/26 6:51 PM, David Heidelberg via B4 Relay wrote:
> > From: Casey Connolly <casey.connolly@xxxxxxxxxx>
> >
> > The SHIFT6mq features an sdcard slot, add it.
> >
> > Signed-off-by: Casey Connolly <casey.connolly@xxxxxxxxxx>
> > Signed-off-by: David Heidelberg <david@xxxxxxx>
> > ---
> >   arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts | 44 +++++++++++++++++++++++
> >   1 file changed, 44 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts b/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
> > index 740eb22550724..c394350998c26 100644
> > --- a/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
> > +++ b/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
> > @@ -600,6 +600,24 @@ &qupv3_id_1 {
> >   	status = "okay";
> >   };
> >   
> > +&sdhc_2 {
> > +	status = "okay";
>
> couple nits:
>
> Status should be last, although the file is all over the place
>
> > +
> > +	pinctrl-names = "default";
> > +	pinctrl-0 = <&sdc2_default_state &sdc2_card_det_n>;
>
> preferably in this order
>
> xxx
> xxx-names
>
> [...]
>
> > +	sdc2_default_state: sdc2-default-state {
> > +		clk-pins {
> > +			pins = "sdc2_clk";
> > +			bias-disable;
> > +			drive-strength = <16>;
>
> All other pin definitions in this file have the bias property below
> drive-strength (like the card_det_n node you're adding)
>
> other than that
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>

Thanks for catching these, I completly missed that sorting is non-compliant. New 
revision sent w/ ur R-b :)

David

> Konrad

--
David Heidelberg