Re: [PATCH 1/3] dt-bindings: timestamp: Add Tegra264 support

[Jon Hunter]

On 02/04/2026 10:53, Krzysztof Kozlowski wrote:
> On 02/04/2026 11:49, Jon Hunter wrote:
> > On 02/04/2026 09:47, Krzysztof Kozlowski wrote:
> > > On 02/04/2026 10:47, Krzysztof Kozlowski wrote:
> > > > On Wed, Apr 01, 2026 at 09:38:29PM +0000, Suneel Garapati wrote:
> > > > >      reg:
> > > > >        maxItems: 1
> > > > > @@ -112,6 +114,7 @@ allOf:
> > > > >              contains:
> > > > >                enum:
> > > > >                  - nvidia,tegra234-gte-aon
> > > > > +              - nvidia,tegra264-gte-aon
> > > >
> > > > And why exactly the slices are variable here? Explain that in commit
> > > > msg.
> > >
> > > s/Explain/Shortly describe/
> >
> > So this is not related to slices, but indicating the
> > 'nvidia,gpio-controller' property is required for the AON controller.
> > However, maybe your comment still applies and you want the commit
> > message to be explicit that for the AON instance the
> > 'nvidia,gpio-controller' is needed?
>
> You have two devices there - AON and LIC - and variable properties. I
> want answer why things are variable. HW is rarely variable. It is
> opposite of variable - afixed.

So note that 'nvidia,slices' is a deprecated property ...

1815e37b6e67 ("dt-bindings: timestamp: Deprecate nvidia,slices property")

I am guessing we did not bother to specify the slices for Tegra264 
because this is no longer being used/supported. And yes, we should have 
made this clear in the commit message :-)

Do you want the commit message updated?

Jon

--
nvpublic