Re: [PATCH] power: sequencing: pcie-m2: add SERIAL_DEV_BUS dependency

[Bartosz Golaszewski]

On Thu, Apr 2, 2026 at 5:42 PM Arnd Bergmann <arnd@xxxxxxxx> wrote:
>
> On Thu, Apr 2, 2026, at 17:38, Bartosz Golaszewski wrote:
> > On Wed, Apr 1, 2026 at 9:10 PM Arnd Bergmann <arnd@xxxxxxxxxx> wrote:
> >> diff --git a/drivers/power/sequencing/Kconfig b/drivers/power/sequencing/Kconfig
> >> index 77c6d9227251..1c5f5820f5b7 100644
> >> --- a/drivers/power/sequencing/Kconfig
> >> +++ b/drivers/power/sequencing/Kconfig
> >> @@ -39,6 +39,7 @@ config POWER_SEQUENCING_PCIE_M2
> >>         tristate "PCIe M.2 connector power sequencing driver"
> >>         depends on OF
> >>         depends on PCI
> >> +       depends on SERIAL_DEV_BUS
> >>         select OF_DYNAMIC
> >>         help
> >>           Say Y here to enable the power sequencing driver for PCIe M.2
> >> --
> >> 2.39.5
> >>
> >
> > I assume with this patch[1] from Mani, we no longer need this one?
> >
> > [1]
> > https://lore.kernel.org/all/20260401070735.107162-2-manivannan.sadhasivam@xxxxxxxxxxxxxxxx/
>
> Depends on which one you mean with 'this one'.
>
> My patch is needed with or without Mani's, while
> his patch is harmless but does not fix the issue.
>
>      Arnd

Mani's patch adds stubs for the symbols that the linker couldn't find
in the build error you posted above. I thought this would fix the
issue?

Bart