Re: [PATCh v3 10/14] ASoC: rsnd: adg: Add per-SSI ADG and SSIF supply clock management

From: Mark Brown

Date: Thu Apr 02 2026 - 14:04:08 EST


On Thu, Apr 02, 2026 at 06:24:32PM +0200, John Madieu wrote:

> @@ -376,6 +431,18 @@ int rsnd_adg_ssi_clk_try_start(struct rsnd_mod *ssi_mod, unsigned int rate)
> (ckr) ? adg->brg_rate[ADG_HZ_48] :
> adg->brg_rate[ADG_HZ_441]);
>
> + /*
> + * RZ/G3E: enable per-SSI and supply clocks
> + * Prepare was done in hw_params
> + */
> + ret = clk_enable(adg->clk_adg_ssi[id]);
> + if (ret)
> + dev_warn(dev, "Cannot enable adg.ssi.%d ADG clock\n", id);
> +
> + ret = clk_enable(adg->clk_ssif_supply);
> + if (ret)
> + dev_warn(dev, "Cannot enable SSIF supply clock\n");
> +

Should we not return an error if we can't start the clocks for some
reason?

Attachment: signature.asc
Description: PGP signature